faban icon indicating copy to clipboard operation
faban copied to clipboard

runStatus changes to COMPLETED before run finishes logging

Open willr3 opened this issue 6 years ago • 1 comments

The GenericBenchmark.start() changes runStates to Run.COMPLETED but there are still several run related steps that can log to the run log or potentially hang. I do not see a runStatus to indicate the run is COMPLETED and all run logs are no longer active. I propose we either change where the run is marked COMPLETED or add a new status to indicate the run is no longer changing any of the artifacts.

willr3 avatar Mar 19 '18 14:03 willr3

It looks like you are integrating with another piece of software. That hoovers up these artifacts after Faban has manage a run. The obvious thing is to move the assignment and it's enclosing if block to line 326. Can you try testing that to see if that solves your problem? Then create a PR if it does.

whitingjr avatar May 03 '18 07:05 whitingjr