Mismatch in Arguments

[gvermaredrock]

In Line 180 of gpt2_model, we define the function as: def distributed_train_step(self,inputs, targets,step,grad_clip=True, clip_value=1.0):

But In line 229, we instantiate it as: train_loss = self.distributed_train_step(inputs, step)

The targets variable / argument is missing.

[rfebbo]

Is there a fix for this?

[gvermaredrock]

Hi, can you please tell if this will be fixed? Thanks

[akanyaani]

Hi,

Sorry for the late reply, I was quite busy in another project, I will fix this and another issue in this repository by end of this week.

Thanks

On Wed, Sep 16, 2020 at 11:53 PM gvermaredrock [email protected] wrote:

Hi, can you please tell if this will be fixed? Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/akanyaani/gpt-2-tensorflow2.0/issues/5#issuecomment-693579476, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWLBKBU5YW72DKNXTJ2S73SGD7AXANCNFSM4N4GEXXA .

[gvermaredrock]

Thanks Man, really looking forward to it. :)

[akanyaani]

Hi @rfebbo, @gvermaredrock , I have fixed the issue, please let me you find another issue.

[nasheedyasin]

great, thanks man. please close the bug then as it is misleading