AkamaiOPEN-edgegrid-node icon indicating copy to clipboard operation
AkamaiOPEN-edgegrid-node copied to clipboard

use the max-body from edgerc or from optional argument passed to Edge…

Open ghost opened this issue 9 years ago • 6 comments

Akamai Forward rewrite Cloudlet api has a max-body size of 131072. The current node implementation uses a hard coded value of 2048. This change allows the value to come from the edgerc file or from the initialization of the EdgeGrid object in api.js.

The default value of 2048 is still used if a value is not passed during initialization.

ghost avatar Nov 06 '15 00:11 ghost

Looks good to me.

ktyacke avatar Nov 19 '15 18:11 ktyacke

What about current users that have a max-body size in edge.rc that is not 2048. The value will now be picked up. Will this break them?

ghost avatar Nov 20 '15 17:11 ghost

Steve, Sorry for the delay in comment on this one, finally getting caught up. I think it should work fine, but would you be able to do a quick merge and re-commit your changes so I can pull it down and test?

ktyacke avatar Dec 08 '15 14:12 ktyacke

I'm at the node conference in Portland, I will try to get to it Friday

On Tuesday, December 8, 2015, ktyacke [email protected] wrote:

Steve, Sorry for the delay in comment on this one, finally getting caught up. I think it should work fine, but would you be able to do a quick merge and re-commit your changes so I can pull it down and test?

— Reply to this email directly or view it on GitHub https://github.com/akamai-open/AkamaiOPEN-edgegrid-node/pull/1#issuecomment-162894995 .

ghost avatar Dec 08 '15 23:12 ghost

No worries Steve, thanks! Hope the conference is going well!

ktyacke avatar Dec 09 '15 03:12 ktyacke

@stevemcginnis Any interest in pushing forward with this PR?

ktyacke avatar Nov 29 '16 14:11 ktyacke

Hi, since this PR was very old we decided to fix this on our own. The fix is ready with recent release. Closing this PR.

lkowalsk-akamai-com avatar Jan 26 '23 13:01 lkowalsk-akamai-com