AkamaiOPEN-edgegrid-golang icon indicating copy to clipboard operation
AkamaiOPEN-edgegrid-golang copied to clipboard

Akamai should not mutate, or log to, the global Logrus logger

Open connor4312 opened this issue 7 years ago • 2 comments

This library interferes with application logging by logging its own data and even mutating the global log level (!). Additionally, it seems that the logging can log secrets to disk (I can see access tokens in what's logged) which is not permitted under our security practices.

Instead, the library should take in some kind of logging interface in the edgegrid.Config. In its absence, it could use a default logger to print to stdout.

connor4312 avatar Oct 17 '17 21:10 connor4312

I absolutely agree with this; and should probably have been done when migrating to the new package structure which didn't need to maintain BC.

We'll discuss this internally and see what the best approach is for minimal impact.

dshafik avatar Oct 17 '17 22:10 dshafik

Great, thanks!

connor4312 avatar Oct 17 '17 23:10 connor4312

@connor4312 - Logrus is no longer used in the lates version of Edgegrid library.

lkowalsk-akamai-com avatar Mar 23 '23 14:03 lkowalsk-akamai-com