darglint2 icon indicating copy to clipboard operation
darglint2 copied to clipboard

`doc_extract` docstring type radio button doesn't work

Open akaihola opened this issue 2 years ago • 0 comments

Background

  • doc_extract -s repos.txt -o docstrings.json accepts local Git repo paths in repos.txt and writes docstrings and metadata into docstrings.json.
  • The Elm webapp accepts docstrings.json and lets the user interactively choose the type of each docstring, discard docstrings, and save the result back into output.json.
  • output.json can then be used for integration tests.

Problem

Clicking on radio buttons to toggle the docstring type in the webapp seems to always cause Google to be selected, with no JavaScript errors or anything suspicious in the Elm debug log.

From @terrencepreilly in this comment:

Likely, something changed in the intervening years since this was written. There's sometimes some strange corners around Elm with custom event listeners (and looks like the radio buttons have to use custom radio buttons.)

The last update to the webapp in 6824be4dbb15c08e8a1975b99520e3282c29e541 was in February 2020. The NumPy docstring type seems to have been added then, along with some changes to the docstring type logic. Also Elm was updated from 0.19.0 to 0.19.1 (which had come out in Oct 2019).

Originally posted by @akaihola in https://github.com/akaihola/darglint2/pull/1#discussion_r1102349675

akaihola avatar Feb 18 '23 19:02 akaihola