Antti Kaihola

Results 359 comments of Antti Kaihola

In #361 we're changing the CI setup so Flake8 is run directly in its own workflow instead of through the Pytest plugin. That should make it unnecessary to address this...

I think I ran into a dead end and started to doubt whether this can be done at all.

Oh wow, another splendid idea! But I agree with your notes regarding options, config file first, and the AST check challenge. Also, I'm not sure if you meant this by...

@Carreau do you still think this patch would fit Darker's purpose? If so, we probably need to try and rebase on `master` – I can help there if the conflicts...

@Carreau, I rebased this on `master` and removed the actual call to the `pyup()` function since it needs to be thought through anyway. I only now looked more closely to...

This makes most sense if we move all checks from the workflow to pre-commit, and just run pre-commit from the workflow, right? I'm a bit torn on this, since I...

[`pre-commit` documentation](https://pre-commit.com/#pre-commit-run) describes the `pre-commit run` option `[hook-id]`: >Options: > >- `[hook-id]`: specify a single hook-id to run only that hook. >Some example useful invocations: >- [...] >- `pre-commit run...

For the 1.5.0 version, we'll keep running checks directly from GitHub workflows. Let's consider `pre-commit` in 1.6.0. Thanks again @cclauss!

@brtknr, if that's the case, we should investigate. If you run Black in a pre-commit hook with a similar folder ignore configuration, does it ignore that folder? If pre-commit calls...

Thanks for the heads-up @guettli, I've never taken a look at `blue` before. Do you know if the internals are at all similar to `black`'s? Darker uses the Python (non-public,...