obsidian-extract-pdf-highlights icon indicating copy to clipboard operation
obsidian-extract-pdf-highlights copied to clipboard

No effect on clicking extract PDF icon

Open justresearch547 opened this issue 3 years ago • 8 comments

Hello @akaalias,

Thank you for creating the plug in.

I have been trying to use it but it does not seem to work. These are the steps I have followed:

  1. I highlight the text on PDF (on a PDF preview or acrobat reader)
  2. I import the pdf into obsidian by dragging it.
  3. I preview the pdf into obsidian
  4. I click the pdf icon on the left bar.
  5. No new file is created with the annotations.

Could you suggest how to address the issue?

Thank you. Regards

justresearch547 avatar May 28 '21 18:05 justresearch547

Hello @akaalias ,

I realised that the plug-in works when one opens the PDF as an attachment in Obsidian. (not while its being viewed as an embedded note in a note)

Is there a way to make it work on the notes page itself?

Thank you.

Regards

justresearch547 avatar May 30 '21 16:05 justresearch547

I also met the same problem.

Obsidian version: v0.12.19

JavanTang avatar Dec 17 '21 00:12 JavanTang

Same problem. Obsidian version: v0.13.23 Highlighted PDF with Adobe Acrobat, shows highlight in Obsidian preview but nothing happens when I press the PDF icon.

frangkli avatar Feb 03 '22 08:02 frangkli

Hello @akaalias ,

I realised that the plug-in works when one opens the PDF as an attachment in Obsidian. (not while its being viewed as an embedded note in a note)

Is there a way to make it work on the notes page itself?

Thank you.

Regards

Same problem

mauroentropico avatar Jun 12 '22 11:06 mauroentropico

If you see no effect, it's likely because there's some sort of error. So what I had to do is open up the Dev Tools Console and that's when I saw my specific errors:

image

huyz avatar Aug 01 '22 19:08 huyz

I'm having a similar issue, console error is below. It seems like this plugin doesn't properly parse all PDFs.

plugin:obsidian-extract-pdf-highlights:78714 Error: ReferenceError: spaceWidth is not defined
eval @ plugin:obsidian-extract-pdf-highlights:78714
Promise.then (async)
eval @ plugin:obsidian-extract-pdf-highlights:78711
step @ plugin:obsidian-extract-pdf-highlights:81
eval @ plugin:obsidian-extract-pdf-highlights:62
eval @ plugin:obsidian-extract-pdf-highlights:55
__awaiter @ plugin:obsidian-extract-pdf-highlights:51
PDFAnnotationsManager.fetchRawAnnotationsFromPDF @ plugin:obsidian-extract-pdf-highlights:78646
eval @ plugin:obsidian-extract-pdf-highlights:78803
step @ plugin:obsidian-extract-pdf-highlights:81
eval @ plugin:obsidian-extract-pdf-highlights:62
fulfilled @ plugin:obsidian-extract-pdf-highlights:52
Promise.then (async)
step @ plugin:obsidian-extract-pdf-highlights:54
eval @ plugin:obsidian-extract-pdf-highlights:55
__awaiter @ plugin:obsidian-extract-pdf-highlights:51
ExtractPDFHighlightsPlugin.processPDFHighlights @ plugin:obsidian-extract-pdf-highlights:78788
eval @ plugin:obsidian-extract-pdf-highlights:78780
plugin:obsidian-extract-pdf-highlights:78755 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'filter')
    at PDFAnnotationsManager.filterRawAnnotations (plugin:obsidian-extract-pdf-highlights:78755:57)
    at ExtractPDFHighlightsPlugin.eval (plugin:obsidian-extract-pdf-highlights:78806:69)
    at step (plugin:obsidian-extract-pdf-highlights:81:23)
    at Object.eval [as next] (plugin:obsidian-extract-pdf-highlights:62:53)
    at fulfilled (plugin:obsidian-extract-pdf-highlights:52:58)

sparky005 avatar Sep 19 '22 15:09 sparky005