prioritab icon indicating copy to clipboard operation
prioritab copied to clipboard

add firefox support using storage.local

Open kneekill opened this issue 8 years ago • 2 comments

  • add ./prioritab-firefox-bundle with edits (chrome.storage.sync -> chrome.storage.local) to prioritab.min.js and lib/sortaeditalist.js to support Firefox

Firefox 57 does not currently support chrome/browser.storage.sync, I would've made changes directly to ./prioritab-bundle but the change to storage.local reduces functionality.

Also, can I post this extension on the Firefox add-on store? I'm switching over to Firefox and would like to continue using this extension and I'm sure there are others in a similar situation.

kneekill avatar Nov 20 '17 01:11 kneekill

Hey kneekill,

Thanks for contributing, and glad to hear you find this extension useful!

General caveat: I'm not actively maintaining this project anymore.

Some initial reactions to your PR:

  • Is the best way to do this by creating a bundle folder that duplicates so many files? Concerned that if somebody changes something in the original project, the changes aren't going to reflect in the Firefox version automatically
  • What needs to change with the Chrome version to make it work with Firefox?
  • I don't mind at all if you publish a version to the Firefox store; please just have a pointer to the Chrome version and this Github repo?

allenjhyang avatar Nov 26 '17 02:11 allenjhyang

Hey!

First of all, sorry for the late response, I somehow missed this when you replied.

You're absolutely right about the duplication of files. It seems that I didn't really think things through when I made this PR. I suppose I got a little over eager with my first PR to an open-source project!

In any case, I just did some quick research and chrome.storage.sync has been supported in Firefox since version 53 with the inclusion of the Firefox application id in the manifest.json D'oh!

If you still don't mind, I can make the manifest.json change, merge and then submit it to the Firefox add-on store with the relevant credit.

kneekill avatar Sep 20 '18 15:09 kneekill