kala icon indicating copy to clipboard operation
kala copied to clipboard
verified publisher icon ajvb

Embed dashboard in binary

Open demianbucik opened this issue 5 years ago • 1 comments

PR to resolve https://github.com/ajvb/kala/issues/228.

To generate and serve embedded files we can use:

  • https://github.com/go-bindata/go-bindata
  • https://github.com/elazarl/go-bindata-assetfs

This adds approximately 0.6 MB to the binary size.

demianbucik avatar Oct 25 '20 23:10 demianbucik

Thanks for this. Care to update the go.sum and I will merge?

tooolbox avatar Sep 22 '22 04:09 tooolbox

Thanks for this. Care to update the go.sum and I will merge?

If Go version gets upgraded to 1.16 or above, I think this can now be done with //go:embed without external dependencies. If you agree, I can change the PR to use //go:embed instead.

Otherwise I'll update the go.sum to merge this as is.

demianbucik avatar Sep 27 '22 08:09 demianbucik

Thanks for this. Care to update the go.sum and I will merge?

If Go version gets upgraded to 1.16 or above, I think this can now be done with //go:embed without external dependencies. If you agree, I can change the PR to use //go:embed instead.

Otherwise I'll update the go.sum to merge this as is.

@tooolbox Nevermind, I just saw on a different PR that you'd prefer to keep Go at 1.13. I merged master branch and updated go.sum. How does it look now?

demianbucik avatar Sep 27 '22 09:09 demianbucik

LGTM

tooolbox avatar Oct 01 '22 17:10 tooolbox