ajv icon indicating copy to clipboard operation
ajv copied to clipboard
verified publisher icon ajv-validator

Fix punycode deprecation warning

Open kibertoad opened this issue 2 years ago • 5 comments

fixes #2350 #2343

What issue does this pull request resolve?

punycode warnings. See linked issues.

What changes did you make?

Switched dependency to a fork that addresses the issue, and which is intended to be maintained for a long time.

Is there anything that requires more attention while reviewing?

No.

kibertoad avatar Feb 09 '24 19:02 kibertoad

@epoberezkin CI appears to be broken in this repo overall. Can I help with that?

kibertoad avatar Feb 09 '24 19:02 kibertoad

@jasoniangreen any chance you could take a look?

kibertoad avatar Feb 16 '24 22:02 kibertoad

Hi @kibertoad sorry for the late reply. I have been speaking to @epoberezkin and he wants me to explore removing uri-js. It's not needed anymore for node given we are dropping older versions, but there is just an open question around browser support. I will update you when I have more.

jasoniangreen avatar Feb 22 '24 23:02 jasoniangreen

great news! thank you

kibertoad avatar Feb 22 '24 23:02 kibertoad

https://github.com/ajv-validator/ajv/pull/2415, also have this PR

tianyingchun avatar Apr 29 '24 01:04 tianyingchun

I think if anything we'll go with https://github.com/ajv-validator/ajv/pull/2415 or moving to a native approach so will close this.

jasoniangreen avatar May 16 '24 21:05 jasoniangreen

@jasoniangreen makes sense. what's preventing #2415 from being merged at this point?

kibertoad avatar May 16 '24 21:05 kibertoad