ajv-validator
Change import package
What issue does this pull request resolve? In fact, some codes that were not needed much have been removed.
What changes did you make?
The recent removal of the line const {default: Ajv} = require('ajv') was made possible by eliminating the export statement module.exports.default = AjvClass. As a result, we no longer require the named import of the Ajv module.
And since we mentioned the following code sample in the documentation, I don't think there is a problem:
const Ajv = require("ajv")
Is there anything that requires more attention while reviewing? require packages in CJS
Or at least it can be as follows:
const {Ajv} = require('ajv')
The following also works:
const Ajv = require('ajv')
I feel the code is cleaner with this method instead of using the code below:
const {default: Ajv} = require('ajv')
@jasoniangreen what happened?!
I just wanted to pull master into your branch so I can see if it passes and do a proper review in the up to date context.
Hi @jasoniangreen, I felt that it has more readability when importing package.
Hi @jasoniangreen, I felt that it has more readability when importing package.
Ah ok, but it would be a potentially breaking change, correct? Depending on how people are currently importing it?
Hi @jasoniangreen, I felt that it has more readability when importing package.
Ah ok, but it would be a potentially breaking change, correct? Depending on how people are currently importing it?
Well, we can make these changes by keeping the previous method and be backward compatible
Hi @jasoniangreen, I felt that it has more readability when importing package.
Ah ok, but it would be a potentially breaking change, correct? Depending on how people are currently importing it?
Well, we can make these changes by keeping the previous method and be backward compatible
@jasoniangreen Done.