ajv icon indicating copy to clipboard operation
ajv copied to clipboard
verified publisher icon ajv-validator

Support for discriminator tag lookup in referenced schemas

Open z6n9n opened this issue 2 years ago • 6 comments

What issue does this pull request resolve? https://github.com/ajv-validator/ajv/issues/2261

What changes did you make? Support for discriminator tag lookup in referenced schemas

Is there anything that requires more attention while reviewing? no

z6n9n avatar May 01 '23 15:05 z6n9n

Is this PR defunct? If you'd consider merging it with changes, I'd be open to contributing the changes back in. We would love to have it support discriminator in https://github.com/pactflow/swagger-mock-validator/issues/51.

mefellows avatar Jan 08 '24 00:01 mefellows

@mefellows What changes would be necessary to get this merged? I'm happy to send another patch with those included.

zoidyzoidzoid avatar Jan 11 '24 09:01 zoidyzoidzoid

I'm not a maintainer here, I'm just an interested party and are open helping out with direction from the project.

mefellows avatar Jan 11 '24 09:01 mefellows

Whoops, my bad. I confused contributor of the pactflow repo with this one!

@epoberezkin would you be able to answer that question?

zoidyzoidzoid avatar Jan 22 '24 09:01 zoidyzoidzoid

@epoberezkin any chance we could get this merged / looked at? it's been over a year and for openapi specs that use discriminator, mapping is required in a lot of cases due to how ref can potentially be rewritten by Ajv it's not as simple as plugging in the values to a static JSON Schema itself.

lifeiscontent avatar Sep 11 '24 00:09 lifeiscontent

@epoberezkin checking in as well, since we'd like to use swagger-mock-validator but mapping is an OpenAPI feature we use quite a bit. Could this be merged?

https://github.com/pactflow/swagger-mock-validator/issues/51

kand avatar Nov 19 '24 15:11 kand