ajv icon indicating copy to clipboard operation
ajv copied to clipboard

ensure that nullable is not set for required parameters

Open erikbrinkman opened this issue 3 years ago • 1 comments

nullable was enforced for optional parameters, but not forbidden for required parameters. This tests and enforces the latter case.

What issue does this pull request resolve?

fixes #2030

at least partially

What changes did you make?

add nullable?: false and tests

Is there anything that requires more attention while reviewing?

nope

erikbrinkman avatar Sep 02 '22 20:09 erikbrinkman

I should note that typescript 4.8 causes errors with the JTD schema type, so I restricted the typescript version too.

erikbrinkman avatar Sep 02 '22 20:09 erikbrinkman

Fixed the error in 4.8 now, so made it >= 4.8

epoberezkin avatar Nov 13 '22 19:11 epoberezkin