ajv icon indicating copy to clipboard operation
ajv copied to clipboard

fixes #2001

Open piliugin-anton opened this issue 3 years ago • 6 comments

fixes #2001

What issue does this pull request resolve? https://github.com/ajv-validator/ajv/issues/2001 What changes did you make? Added if condition to check whether property is first Is there anything that requires more attention while reviewing? Code correctness

piliugin-anton avatar Jul 07 '22 11:07 piliugin-anton

@piliugin-anton thank you!

It needs the test that fails without this change.

epoberezkin avatar Jul 09 '22 18:07 epoberezkin

@epoberezkin should I write a test or you will do it?

piliugin-anton avatar Jul 09 '22 18:07 piliugin-anton

@piliugin-anton it's great if you can - probably should be something similar to this one: https://github.com/ajv-validator/ajv/blob/master/spec/issues/1501_jtd_many_properties.spec.ts

epoberezkin avatar Jul 09 '22 19:07 epoberezkin

@epoberezkin Okay, I will try. Will push the changes in an hour and ping you

piliugin-anton avatar Jul 09 '22 19:07 piliugin-anton

@epoberezkin How do I write a test, when I already have a changes that returns correct result of serialization. Could you please assist me?

piliugin-anton avatar Jul 09 '22 19:07 piliugin-anton

@epoberezkin Please check if test is correct

piliugin-anton avatar Jul 16 '22 19:07 piliugin-anton

amended in #2190

epoberezkin avatar Jan 02 '23 21:01 epoberezkin