ajv icon indicating copy to clipboard operation
ajv copied to clipboard

Published 20 hours ago • verified publisher icon ajv-validator

export ValidationError and MissingRefError

Open Ginden opened this issue 3 years ago • 5 comments

What issue does this pull request resolve?

#1832

What changes did you make?

Exported 2 Error subclasses.

Is there anything that requires more attention while reviewing?

Ginden avatar Dec 10 '21 15:12 Ginden

Never saw this export format before :)

It should be added in other ajv classes too - core.ts, jtd.ts, 2019.ts and 2020.ts

epoberezkin avatar Dec 11 '21 23:12 epoberezkin

Probably no need to export from core.ts.

epoberezkin avatar Dec 11 '21 23:12 epoberezkin

What is required to get this over the line? Im hitting alot of issues trying to upgrade a codebase. Happy to get involved if possible

dannyb648 avatar Jun 24 '22 15:06 dannyb648

@dannyb648: It should be added in other ajv classes too - jtd.ts, 2019.ts and 2020.ts

epoberezkin avatar Jun 26 '22 22:06 epoberezkin

@dannyb648: It should be added in other ajv classes too - jtd.ts, 2019.ts and 2020.ts

I've added these changes and the original ones to PR #2020 - Any chance of a review? Additionally looks like something is broken with the coverage plugin on all the PRs atm?

dannyb648 avatar Jun 28 '22 09:06 dannyb648