ajv icon indicating copy to clipboard operation
ajv copied to clipboard

Extend discriminator to support number and boolean values

Open pkuczynski opened this issue 2 years ago • 9 comments

What issue does this pull request resolve?

Part of #1663 - as discussed in the thread...

What changes did you make?

Extending discriminator to support number and boolean types.

Is there anything that requires more attention while reviewing?

I have not changed jtd as I was not even sure if I should or not?

pkuczynski avatar Aug 05 '21 12:08 pkuczynski

Great - thank you - made some comments

epoberezkin avatar Aug 06 '21 09:08 epoberezkin

@pkuczynski can you do review changes? it's useful feature

Froctnow avatar Jul 27 '22 04:07 Froctnow

I'd also like to use this feature.

@pkuczynski let me know if you don't have time for it, I can take it form here.

fredericosilva avatar Oct 26 '22 16:10 fredericosilva

@Froctnow @fredericosilva I just pushed changes requested by @epoberezkin.

@epoberezkin can you have a look again and resolve threads if you are happy with my changes?

pkuczynski avatar Oct 26 '22 20:10 pkuczynski

@epoberezkin I am not sure where did the build failure came from, as I haven't touched those files. Can you help me to solve it?

pkuczynski avatar Oct 26 '22 20:10 pkuczynski

Hey, any progress on this? I could really use this feature

MxtOUT avatar Apr 06 '23 08:04 MxtOUT

@MxtOUT I am still waiting for the feedback from @epoberezkin...

pkuczynski avatar Apr 06 '23 08:04 pkuczynski

We'd love to get this fix merged, @epoberezkin @pkuczynski any update on this?

enzolupia avatar Sep 18 '23 08:09 enzolupia

I am waiting for the feedback from @epoberezkin...

pkuczynski avatar Sep 18 '23 23:09 pkuczynski