ajv-errors icon indicating copy to clipboard operation
ajv-errors copied to clipboard
verified publisher icon ajv-validator

fix(deps): move ajv from devDepenencies to dependencies

Open rublea opened this issue 4 years ago • 4 comments

rublea avatar May 10 '21 16:05 rublea

@epoberezkin I believe ajv should be added as a dependency to this project. Can you approve the workflow ?

rublea avatar May 10 '21 16:05 rublea

@epoberezkin Would you have time to take a look on this PR, it's a small one ?

rublea avatar May 12 '21 06:05 rublea

can this be merged? it fixes this error:

Error: Cannot find module 'ajv/dist/compile/codegen'
Require stack:
- /some/project/node_modules/ajv-errors/dist/index.js

solaris007 avatar May 12 '21 11:05 solaris007

I think this PR is really important, we have an issue with the submodule which depends on ajv-errors and on the main module, it points to the outdated version of ajv because it is already installed by other modules which install the outdated version. Our current solution is to install it directly on the main module and then remove it to make sure ajv on node_modules is compatible with ajv-errors but we think it is not scalable solution.

mustafamilyas avatar Nov 25 '21 02:11 mustafamilyas