Andrew Tritt

Results 37 comments of Andrew Tritt

It shouldn’t be. What’s the point of inheritance if you can just toss out everything you inherit?

What if we just make a new subtype of the base TimeSeries where *data* stores cluster ids?

Yeah, we would keep SpikeEventSeries, and just add a new type.

keyword arguments are optional, positional arguments are required. You can see which arguments are keyword and which are positional by looking at the method signature.

If you want to add something "(optional)" to the arguments list in the documentation, you would need to modify [pynwb.form.utils.__googledoc](https://github.com/NeurodataWithoutBorders/pynwb/blob/dev/src/pynwb/form/utils.py#L416)

In the order that you asked your questions: - Yes. PyNWB is just writing HDF5 files... there is nothing about these files that prevents you from opening them up with...

> Do we need to subclass DynamicTable or is there a better way? No, you would need to subclass [DynamicTableMap](https://hdmf.readthedocs.io/en/latest/hdmf.common.io.table.html#hdmf.common.io.table.DynamicTableMap) and extend [get_attr_value](https://hdmf.readthedocs.io/en/latest/hdmf.build.map.html#hdmf.build.map.ObjectMapper.get_attr_value)

hey @afonsobspinto, look at the __getitem__ implementation on LabelledDict. I apologize for the lack of documentation--as @bendichter said, it's not finished. https://github.com/NeurodataWithoutBorders/pynwb/blob/6d2cc9f8ed3ab1a67e2da2fb4fec77029aed2215/src/pynwb/core.py#L43

> I'm wondering whether there may be an issue with the ObjectMapping here @oruebel you are correct. ObjectMapping is choking on having a Container passed as a concrete dataset. The...

The NWBFile will need a place to store this information. I think adding an attribute is a logical place to do that. https://github.com/NeurodataWithoutBorders/nwb-schema/blob/7931e59ad1e97433ce4a450fa5bc2dab81af6f8d/core/nwb.file.yaml#L7-L12