Alastair Robertson

Btw, I like how much simpler your method is for generating a DWARF data source - maybe we could switch the C data source across to that way in the...

> Also, the individual commits are not very clean and very likely won't work on their own. I'm ok with that as long as we squash the PR in the...

Just had a quick skim, but we should try and keep the ELF file in memory until the actual serialisation step. `CodegenLLVM::emit_elf` is just a tool for debugging bpftrace. Take...

> > We also discussed about `sargX` with @ajor and concluded it typically won't return the correct argument for other languages like Go. > > Yes, Go uses their own...

> > I'm wondering if we can have a more descriptive name for the "probe_inline" config option. We don't want to keep this global setting as a long term solution...

Looking good to me. I think the only remaining piece is to decide about `sarg`. > In fact, the new Go conventions even break the `argX` builtins as those follow...

> But, if the user doesn't have DWARF symbols for his binary, knows the ABI, and wants to see values of stack-passed args, why not let him do it, especially...

Let's go! 🚀

> About the verifier errors: that's something we unfortunately have to live with. The verifier is expected to get better at proving the halting of recursive calls but as the...

It looks like the problem occurs when the `BEGIN` and `END` probes run on different CPUs: ``` BEGIN { $i = 0; while ($i < 100) { @m[cpu] = count();...