Alastair Robertson

The clang-format failure is annoying - my local clang-format puts it in the way I've got it but the CI wants it laid out differently.

> IMO the use of `operator()` makes everything look too much like a function call. Which I suppose on a really technical level is true. But kinda misleading to read...

I suppose I could refactor it into this form which would get rid of the need for the custom operators: ``` class Unop { public: Expression &expr() { return expr_;...

This feature is a good example of something where #3521 would be useful if we had it - it's a good feature to add but I don't think we're settled...

To throw out another idea for probe naming that combines two cases we'd eventually want to support: ``` trigger:signal:SIGUSR1 {} trigger:keypress:space {} ```

> What is the purpose of using the `trigger:` or `event:` prefix? To logically group probe types which fire when the bpftrace process is a target of an event (signal,...

Maybe related, this script crashes bpftrace with a "Floating point exception": ``` BEGIN { @map1[@map2] = 1; @map2 = 1; for ($kv : @map1) { } } ``` Please check...

Recommend leaving this until after #3390 is merged as there will be conflicts.

Confirmed, this looks like a flakey test: https://github.com/bpftrace/bpftrace/blob/36c4b72c5d251a1e2778518a5df6a1c4684a6264/tests/runtime/variable#L53 The script triggers an exit when the `wait4` system call returns: ``` tracepoint:syscalls:sys_enter_wait4 /args.ru/ { @ru[tid] = args.ru; } tracepoint:syscalls:sys_exit_wait4 /@ru[tid]/ {...

I think we should change the join behaviour despite the problems raised. We can block its use in situations which are currently not possible, e.g. assigning to variables and maps,...