homarr icon indicating copy to clipboard operation
homarr copied to clipboard

Image connection broken (still)

Open WahidBawa opened this issue 2 years ago • 6 comments

Environment

Docker

Version

0.9.1

Describe the problem

Similar to #335, some of my icons are broken on just the main dashboard. When I click they show up just fine.

My situation is a bit different from #335, I'm using direct URLs to the png. https://cdn.overleaf.com/img/ol-brand/overleaf_og_logo.png for example. slightly

Additional info

Doesn't work: image image image

Main Dashboard: image

Please tick the boxes

  • [X] You've read the docs
  • [X] You've checked for duplicate issues
  • [X] You've tried to debug yourself

WahidBawa avatar Aug 11 '22 20:08 WahidBawa

Hey can you pull again ? I hot fixed the image 2 hours ago 😅

Tell me if you still have the issue in the latest latest (i know you said still, but I believe you have the wrong version because the latest one uses the same methods to show images in both places)

ajnart avatar Aug 11 '22 20:08 ajnart

Yeah the issue is even with the hotfixed version.

I docker rmi'd all versions of it and still have the same issue.

I just tried the image with the dev tag and that's working perfectly fine. Tried it with the latest tag after the rmi's and the issue is still there.

WahidBawa avatar Aug 11 '22 20:08 WahidBawa

Yeah the issue is even with the hotfixed version.

I docker rmi'd all versions of it and still have the same issue.

I just tried the image with the dev tag and that's working perfectly fine. Tried it with the latest tag after the rmi's and the issue is still there.

That's very strange. Can you compare the checksum of the image?

Edit : sha256:ba99d8c6a17505f40a593f7585b85398c17f3623b20b8231c4be53c7e7beac3b

should be the value

ajnart avatar Aug 11 '22 20:08 ajnart

image This is what I get for the 2 images. latest: sha256:ba99d8c6a17505f40a593f7585b85398c17f3623b20b8231c4be53c7e7beac3b dev: sha256:655a4bdc0b05f8fa6598c40c3ca497220a6430240d15bb8b6bc821866b918a89

WahidBawa avatar Aug 11 '22 20:08 WahidBawa

That is strange because dev still has the caching feature enabled. You probably can't have local images but you are encountering another issue but the display method to show images in the add service menu and the app shelf should be the same in the latest version.

I'll investigate further

ajnart avatar Aug 11 '22 20:08 ajnart

I can confirm Its broken. All #personal added icon urls stop to show in the latest version. The problem it's on dashboard. I currently use the latest version 0.9.1

mariushosting avatar Aug 11 '22 21:08 mariushosting

@mariushosting can you send me the failing http requests or some logs please?

ajnart avatar Aug 12 '22 05:08 ajnart

@mariushosting can you send me the failing http requests or some logs please? warn - using beta Middleware (not covered by semver) - https://nextjs.org/docs/messages/beta-middleware Error: 'sharp' is required to be installed in standalone mode for the image optimization to function correctly Error: 'sharp' is required to be installed in standalone mode for the image optimization to function correctly Error: 'sharp' is required to be installed in standalone mode for the image optimization to function correctly

mariushosting avatar Aug 12 '22 07:08 mariushosting

Same problem here, the log looks similar to @mariushosting

EnfermeraSexy avatar Aug 12 '22 09:08 EnfermeraSexy

Same problem here, the log looks similar to @mariushosting

these are the server logs, can you show me your dev tool logs / network tab requests failing ?

ajnart avatar Aug 12 '22 09:08 ajnart

This is what you want? image

EnfermeraSexy avatar Aug 12 '22 09:08 EnfermeraSexy

Same log errors here the latest update broke something.

mariushosting avatar Aug 12 '22 09:08 mariushosting

Similar logs to me aswell

The13thTimelord avatar Aug 12 '22 11:08 The13thTimelord

Can you confirm that this has been fixed with https://github.com/ajnart/homarr/releases/tag/v0.9.2?

ajnart avatar Aug 12 '22 13:08 ajnart

Can you confirm that this has been fixed with https://github.com/ajnart/homarr/releases/tag/v0.9.2?

Fixed!

mariushosting avatar Aug 12 '22 13:08 mariushosting

Fixed for me aswell! Cheers!

The13thTimelord avatar Aug 12 '22 16:08 The13thTimelord

Can you confirm that this has been fixed with https://github.com/ajnart/homarr/releases/tag/v0.9.2?

Has been fixed. Thanks for the great work.

WahidBawa avatar Aug 12 '22 16:08 WahidBawa