homarr icon indicating copy to clipboard operation
homarr copied to clipboard

default icons pathing change

Open No-Maines-Land opened this issue 2 years ago • 4 comments

Environment

Docker

Version

0.14.0

Describe the problem

When using icons stored in /app/public/icons, the new update has changed the naming convention to automatically add "." before the icon. This breaks icon and requires manual revision. This change in new in 0.14 from 0.13

What Homarr is doing: image

What I think Homarr should be doing: image

This also stops the list of preloaded icons from appearing when the icon is blank: image

Logs

No response

Context

No response

Please tick the boxes

  • [X] I confirm that I attached the proper logs
  • [X] I've read the docs
  • [X] I've checked for duplicate issues
  • [X] I've tried to debug myself

No-Maines-Land avatar Nov 11 '23 01:11 No-Maines-Land

Possible source of the problem: https://github.com/ajnart/homarr/blob/v0.14.0/src/tools/server/images/local-icons-repository.ts // line 32: url: ./icons/${file},

No-Maines-Land avatar Nov 11 '23 02:11 No-Maines-Land

Thanks for your investigation! I’m not sure what causes the issue since the file you’ve referred to has been last updated 5 months ago but I’ll try to take a look at what could be causing the issue.

Do you know if it worked properly before in v0.13.4 ?

ajnart avatar Nov 11 '23 08:11 ajnart

if u reboot the container it see the image filename but sometimes u get 0 bites images

example https://cdn.jsdelivr.net/gh/walkxcode/dashboard-icons/png/jellyfin.png

this gets loaded when detected with 0 bites this is because it inserts /board/ in the path

so u need to change the way you run the container, something like

docker run  \
  --name homarr \
  --restart unless-stopped \
  -p 7575:7575 \
  -v /var/run/docker.sock:/var/run/docker.sock \
  -v <your-path>/homarr/configs:/app/data/configs \
  -v <your-path>/homarr/data:/data \
  -v <your-path>/homarr/icons:/app/public/board/icons \ 
  -d ghcr.io/ajnart/homarr:latest

notice the line /app/public**/board/**icons \

@ajnart u want to change the documentation or the code?

icf20 avatar Nov 13 '23 02:11 icf20

Hello 👋, this issue has been open for 60 without activity. Please close this issue if it's no longer relevant or has been resolved. Still relevant? Simply reply and I'll mark it as active.

github-actions[bot] avatar Jan 12 '24 17:01 github-actions[bot]