sharkiq icon indicating copy to clipboard operation
sharkiq copied to clipboard

Added support for shark europe devices

Open TheLastFrame opened this issue 3 years ago • 10 comments

Hi, due to shark European devices using different servers then shark US devices, I added support for the European servers. I tested it with the Shark RV1000SEU

TheLastFrame avatar Jun 25 '21 20:06 TheLastFrame

Testet it with a Shark RV1100S1EU and can also confirm login works in EU

captrik avatar Jan 06 '22 15:01 captrik

@captrik great to hear! I can't seem to make this branch work on HA, could you please give some indication on how you made it work ? (I assume that you did not use HACS) Thanks!

creativeosmose avatar Jan 19 '22 09:01 creativeosmose

@captrik great to hear! I can't seem to make this branch work on HA, could you please give some indication on how you made it work ? (I assume that you did not use HACS) Thanks!

Hi, I testet it by manually running the PR version of this library with python (not the HA integration itself) as shown in the example in the Readme.

The HA integration (which just uses this package) will need some changes too in order to work with the "europe option"

captrik avatar Jan 19 '22 10:01 captrik

Hi, I testet it by manually running the PR version of this library with python (not the HA integration itself) as shown in the example in the Readme.

The HA integration (which just uses this package) will need some changes too in order to work with the "europe option"

I see, thanks. By doing so, do you see it in HA? or is it only running independently?

creativeosmose avatar Jan 19 '22 10:01 creativeosmose

No this was completely independent from HA

captrik avatar Jan 19 '22 11:01 captrik

Understood, thanks for your quick feedback!

creativeosmose avatar Jan 19 '22 11:01 creativeosmose

@TheLastFrame given the API endpoint woes we're seeing again this week, I suspect the EU URLs may need to be updated as well. There is a PR open on the Home Assistant repo to update the shark dependency to a fork of this repo that is actively maintained. Could you check the URLs & resubmit your PR on that repo so we can get it merged in? https://github.com/JeffResc/sharkiq/

Should be plug & play for the most part.

funkybunch avatar Mar 30 '22 03:03 funkybunch

Oh nice, that someone finally does what I always wanted to do. I will look into it as soon as possible.

TheLastFrame avatar Mar 30 '22 11:03 TheLastFrame

Closed in active fork repo via https://github.com/JeffResc/sharkiq/pull/16

funkybunch avatar Apr 15 '22 02:04 funkybunch

Hi was the EU feature all merged and completed please? I get the 'unexpected error' message but unsure if it is to do with the EU issue, or something else.

gtisi avatar Jan 09 '23 17:01 gtisi