ajmandourah

> Another approach is to add a condition here instead of adding a terminfo entry: > ```c > // Extended underline. > // terminfo will have Smulx for this (but...

after some testing it seems like adding Setulc caused some issue when scrolling around . was noticed when using nvim-tree plugin but I recon this will also affect multiple windows....

Is there anything left to be done here?

> Fix the failing tests and squash your commits? thanks. I am new to git. will look it up

I tried changing getenv() to os_getenv() as recommended by lint. it compiles fine in visual studio but does not pass the test. any ideas to proceed?

> Looks great. > > You can apply the suggested changes and see if it helps. it compiles in msvc. getting this on lint check ``` FAIL: /home/runner/work/neovim/neovim/src/nvim/tui/terminfo.c (File size...

> Run `make format` locally. Thanks. it passes lint now.

Now FreeBSD is complaingin but looks like an issue with the script.

> There seems to still be some problems: > > * The new terminfo entry is not added to `scripts/update_terminfo.sh`, so it will be removed when the script is next...

> Hmm, it seems that checking `WT_SESSION` environment variable still leads to worse behavior on older Windows Terminal versions. I checked this with Windows Terminal 1.12.10983.0, and a highlight group...