devto-clone icon indicating copy to clipboard operation
devto-clone copied to clipboard

Content projection header

Open ajitsinghkaler opened this issue 3 years ago • 7 comments

Content projection header in article card seems too much shouldn't we use an input param which defines the size of the title of the card and if there is no size given use default title size.

ajitsinghkaler avatar Jul 23 '21 04:07 ajitsinghkaler

@ajitsinghkaler @ChellappanRajan I want you to assign the this me.

NsdHSO avatar Oct 24 '21 20:10 NsdHSO

Assigned it to you

ajitsinghkaler avatar Oct 27 '21 07:10 ajitsinghkaler

Here I not see anything ng-projection ( In component of the header ), please be more specific

NsdHSO avatar Oct 27 '21 20:10 NsdHSO

Its in article-card.component

https://github.com/ajitsinghkaler/devto-clone/blob/main/libs/global-components/src/lib/article-card/article-card.component.html#L17-L24

ajitsinghkaler avatar Oct 30 '21 06:10 ajitsinghkaler

@ajitsinghkaler What more exactly do I have to do ?

NsdHSO avatar Oct 30 '21 19:10 NsdHSO

Here I don't like the way I've implemented it in *ngIf="!ref.hasChildNodes()" I want to change it is there a better structure

ajitsinghkaler avatar Nov 01 '21 07:11 ajitsinghkaler

ok, I take a time, and I try to resolved

NsdHSO avatar Nov 01 '21 10:11 NsdHSO