Flutter-Dotted-Border icon indicating copy to clipboard operation
Flutter-Dotted-Border copied to clipboard

Implement animation to allow rotating border

Open Maatteogekko opened this issue 3 years ago • 4 comments

Solves https://github.com/ajilo297/Flutter-Dotted-Border/issues/20.

I also added the possibility to place the border on top of the child to allow for an internal border using borderPadding.

PS I took the liberty to update the changelog, I hope that's not an issue

Maatteogekko avatar Mar 07 '23 14:03 Maatteogekko

@ajilo297 is there any chance that this can be merged, or at least discussed?

Maatteogekko avatar Nov 11 '23 01:11 Maatteogekko

@Maatteogekko I haven't had time to check the PR yet. I am in the middle of an API update and am planning to review this PR once I have pushed the API update to master. Sometime this week probably 🤞🏻

ajilo297 avatar Nov 19 '23 05:11 ajilo297

@ajilo297 what about??

IldySilva avatar Jul 21 '24 23:07 IldySilva

@ajilo297 quite a bit of time has passed since the last update. This isn't a breaking change, but maybe that is hard to see with all the extra commits. I can rebase the PR to make it easier to review. Would that help?

Maatteogekko avatar Jul 22 '24 22:07 Maatteogekko

@ajilo297 still giving support to this?

IldySilva avatar May 23 '25 14:05 IldySilva

Hi @Maatteogekko. Apologies for coming back to the PR so late. Could you rebase on master and resolve the conflicts please. I will be taking a look at this PR over the course of the coming week

ajilo297 avatar May 23 '25 17:05 ajilo297

@ajilo297 rebase complete! Let me know if you need anything else

Maatteogekko avatar May 26 '25 08:05 Maatteogekko

@ajilo297 🙏

matanshukry avatar Jun 14 '25 21:06 matanshukry

I forgot to pass the animation value in dashed_painter, now it is all working.

Maatteogekko avatar Jun 21 '25 15:06 Maatteogekko

The cleaner solution would be to add support for the animation inside the path_drawing package directly, but that package is no longer being maintained. My PR in the end boils down to adding 10 or so lines of code in the dash_path taken from that package.

Maatteogekko avatar Jun 21 '25 19:06 Maatteogekko