scikit-spatial Added 2D Circle on plane in 3D space

Sphere's intersection on a 2D plane in 3D space is a circle on a plane. Test files and new class with barebone implementation added.

Mar 06 '23 08:03 Yeok-c

Hi @Yeok-c,

Before I do a thorough review of this code, you need to get the PR checks (pre-commit and the tests) to pass. For starters, you need to delete all the commented-out code. For now I'm marking this PR as a draft.

Once these checks have passed, please mark this PR as ready for review and request me as a reviewer.

Mar 06 '23 12:03 ajhynes7

Hi @Yeok-c! Do you need help with this PR? If think this would be a very valuable addition to this library I have already developed something similar here, maybe it can be helpful.

Apr 10 '23 12:04 CristianoPizzamiglio

yeah I'd love some help. I've developed some more features on my fork https://github.com/Yeok-c/scikit-spatial

Circle3D object (a 2D circle on a plane in 3D space), resulting from sphere-plane intersection Elipse3D object (a 2D elipse on a plane in 3D space), resulting from cylinder-plane intersection

and also sphere-sphere-sphere trisection, which results in one points.

All the intersections are intentionally implemented without iterative algorithms, which makes it possible to do differentiable operations later.

The implementations are messy but they work for my purpose. I don't have time to align it with the style in this repo. I wouldn't mind if anyone added them to this repository with minor credits to me.

Apr 11 '23 11:04 Yeok-c

yeah I'd love some help. I've developed some more features on my fork https://github.com/Yeok-c/scikit-spatial

Circle3D object (a 2D circle on a plane in 3D space), resulting from sphere-plane intersection Elipse3D object (a 2D elipse on a plane in 3D space), resulting from cylinder-plane intersection

and also sphere-sphere-sphere trisection, which results in one points.

All the intersections are intentionally implemented without iterative algorithms, which makes it possible to do differentiable operations later.

The implementations are messy but they work for my purpose. I don't have time to align it with the style in this repo. I wouldn't mind if anyone added them to this repository with minor credits to me.

Hi! Sorry, pretty busy at work. I will start working on this very soon!

May 07 '23 23:05 CristianoPizzamiglio

Kudos, SonarCloud Quality Gate passed!