eclipse-instasearch icon indicating copy to clipboard operation
eclipse-instasearch copied to clipboard

Use default value for "Match highlight background color" instead of custom.

Open DenysPanchenko opened this issue 9 years ago • 6 comments

I use dark theme in Eclipse and customize some colors by myself. Regular eclipse consider my changes whereas Insta not. instasearch_issue OS: Windows 7, Eclipse Luna with MoonRise color theme

DenysPanchenko avatar May 14 '15 11:05 DenysPanchenko

Ah yes, looks like the color is hardcoded at the moment https://github.com/ajermakovics/eclipse-instasearch/blob/master/instasearch/src/it/unibz/instasearch/ui/ResultLabelProvider.java#L61 Would be better to get the one from Eclipse. There's probably API to get it somehow...

ajermakovics avatar May 14 '15 20:05 ajermakovics

Hi, may I ask if this issue is going to be fixed?

BR.

omne777 avatar Jul 04 '16 12:07 omne777

I'm using the Darkest Dark theme with Eclipse Oxygen and, despite the PR referenced in #80 looking like it also fixes this issue, I'm still seeing unreadable match highlights. Looking over the code in that PR, it seems that there's a fallback to a hard-coded color (the one that I'm getting which makes the text impossible to read) if the one looked up (for search matches) isn't found. Since the looked-up color (ECLIPSE_SEARCH_UI_MATCH_HIGHLIGHT) isn't found, I'm wondering if this is the correct color to try and use here. As it is, it's not even clear to me which color I should try and modify to make things readable.

Can someone confirm that this is still broken with Eclipse Oxygen and dark themes?

asampal avatar Jun 25 '17 22:06 asampal

Yeah. Still broken.

DanielJoyce avatar Aug 31 '17 21:08 DanielJoyce

Yup still broken, and very annoying.

ferradario avatar Apr 16 '18 15:04 ferradario

Solve in 1.5.7 !

oliverlj avatar Aug 02 '18 15:08 oliverlj