zoxide doesn't work on ksh

[neelchakrabrty]

Hello. I am writing a zoxide port for OpenBSD. The port installs as expected, and zoxide works as expected on supported shells. However, it doesn't work on ksh, which is what is currently blocking the port to be committed by the developers(I am not a developer). I have tried adding eval "$(zoxide init posix --hook prompt)" to my .kshrc but it didn't work. I have tried generating shell config using zoxide init but that threw an error too.
error: invalid value ksh for <SHELL> Are there any known workarounds for this issue? If not, is it possible to add support for ksh?

[ajeetdsouza]

I have tried adding eval "$(zoxide init posix --hook prompt)" to my .kshrc but it didn't work.

ksh is a POSIX-compliant shell, so this should work. Could you describe the exact issue?

[neelchakrabrty]

It was an issue on my end. I forgot to source my .kshrc

[ajeetdsouza]

zoxide v0.9.5 now officially supports ksh. Do try it out whenever you get the chance!

[neelchakrabrty]

I just tried it on OpenBSD-current.

I am getting the following error when I source .kshrc

ksh: trap: -p: unknown option
ksh: trap: bad signal DEBUG

[ajeetdsouza]

Which ksh are you using?

[neelchakrabrty]

The one that is in OpenBSD base install. https://man.openbsd.org/ksh.1

KSH v5.2.14

[ajeetdsouza]

Found the issue. It seems OpenBSD's ksh is lacking in some features:

The original Korn shell's DEBUG trap and the handling of ERR and EXIT traps in functions are not yet implemented.

[neelchakrabrty]

For the time being, the POSIX shell method works. That's good enough for me.

Thank you for helping me and adding support for KSH so quickly.

[ajeetdsouza]

For now I'd suggest using --hook prompt when initializing zoxide, I'll look into it once I'm able.

[ajeetdsouza]

Took a look at this. Unlike bash or zsh, ksh implementations generally don't have any non-POSIX features that would result in a better zoxide plugin, so I'm closing this issue.