eofs icon indicating copy to clipboard operation
eofs copied to clipboard
Published 1 month ago • verified publisher icon ajdawson

Use of deprecated np.product

Open kafitzgerald opened this issue 1 year ago • 1 comments

As of version 1.25.0 np.product was deprecated in favor of np.prod.

There are few uses of this in eofs.

kafitzgerald avatar May 20 '24 00:05 kafitzgerald

I was going to pull together a quick PR, but it looks like someone beat me to it.

kafitzgerald avatar May 20 '24 00:05 kafitzgerald

Unfortunately, #148 isn't merged, yet, and now breaks the eofs package as numpy.product was dropped. :-(

g-voelker avatar Nov 05 '24 10:11 g-voelker

I encountered the same issue, and curious to know if there is any plan for merging PR #148.

lee1043 avatar Nov 06 '24 23:11 lee1043

Hi @kafitzgerald, @g-voelker, @lee1043. Sorry for not getting to this sooner. I have published a v2.0.0 release that resolves these issues. Thanks a lot for contributing, it is appreciated.

ajdawson avatar Nov 15 '24 15:11 ajdawson