Arthur Vickers

The Cosmos provider ignores configured indexes

3

For example: ```C# modelBuilder.Entity().HasIndex(e => e.ByteArray); ``` This will currently pass model validation, but the index is ignored. We should fail for this in model validation.

API review changes

1

Part of #33220 - Replace `IUpdateEntry.GetOriginalOrCurrentValue` with `HasOriginalValue` - Review whether we really need `MigrationsSqlGenerator.SequenceOptions` overload with `forAlter`. Move logic to other methods otherwise. - Remove `IReadOnlySequence.IsCached`. `CacheSize` of `0`...

Cosmos: Support queries into primitive collections

2

Consider: - [x] #25701 - [x] #25700 - [x] Contains - [ ] Join Composition over (non-primitive) embedded collection - see also #16926, #17957

Query, where Region is the top-level partition key: ```C# var customers = await context .Set() .Where(e => e.Id == id && e.Region == region) .ToListAsync(); ``` SQL: ``` info: 8/28/2024...

Don't log inlined values in SQL unless sensitive data logging is enabled

6

See https://github.com/dotnet/efcore/issues/13617#issuecomment-805049723 When EF inline a value, then we will stop logging the SQL unless sensitive data logging is enabled. We will instead log a message indicating that sensitive data...

(RC2) Downgrade to LTS SqlClient

6

Part of #32915 ### Description We develop with the latest SqlClient package so that we have a better chance of catching regressions. However, we cannot release with this package because...

Use the JSON `id` property directly if the mapped property is already converted to a string

1

If the EF primary key property is a string, then we map it directly to the JSON `id` property. If it is numeric (or bool), then we map a string...

Use testcontainer for testing Cosmos DB

10

https://testcontainers.com/modules/cosmosdb/

Add JSON type tests to CSharpMigrationsGeneratorTest and CompiledModelSqlServerTest

1

See https://github.com/dotnet/efcore/pull/34401#issuecomment-2286923548

Test the native JSON type where the principal is mapped to a view.

1

See https://github.com/dotnet/efcore/pull/34401#pullrequestreview-2236541128