Arthur Vickers comments

Results 1127 comments of


                                            Arthur Vickers

Distributed transactions failures when running EF Core tests on main

Haven't see this fail in a while, but did see this last week. Note this is with SqlClient 5.1. ``` Microsoft.EntityFrameworkCore.SqlServer.FunctionalTests.dll Summary Tests run: 42576 — Failures: 2, Skipped: 134,...

Distributed transactions failures when running EF Core tests on main

@roji Just FYI, I now see this maybe 50% of the time when running the tests on my machine.

Distributed transactions failures when running EF Core tests on main

I don't think it is a priority. But I may look at it again just because I like our tests to be green across the board. :-)

Distributed transactions failures when running EF Core tests on main

@ErikEJ Interesting! We'll see if it goes away once we update.

Distributed transactions failures when running EF Core tests on main

@ErikEJ @roji Just saw this while using 5.1.4. 😠 😄

Distributed transactions failures when running EF Core tests on main

Closing as I have not see the issue in main since this change from January.

SQL Server: Set operations should work if normalized store type is the same

Note from design meeting: stop throwing in this case and let the database throw if the types are not compatible.

SQL Server: Set operations should work if normalized store type is the same

Note for triage: we should decide what to do about parameter matching in QuerySqlGenerator.VisitSqlParameter (see https://github.com/dotnet/efcore/pull/29650#discussion_r1030251583).

SQL Server: Set operations should work if normalized store type is the same

Note from triage: since the VisitSqlParameter check is an optimization only, the existing check is fine.

Document pre-convention model configuration

Updated AKA link