BigGAN-PyTorch icon indicating copy to clipboard operation
BigGAN-PyTorch copied to clipboard

groupnorm function in layers.py

Open songyh10 opened this issue 5 years ago • 1 comments

Hi, when I read the code in layers.py, I found that in L322, the input is x and self.normstyle, but there is no self.normstyle in the previous definition. Should it be self.norm_style? In the definition of groupnorm function in L259, the norm_style could have the format of "ch_32" or "grp_16", but if this norm_style is the self.norm_style in L322, it could only be a choice of "bn", "ln", "in", or "gn". Therefore, I feel quite confused about the function here. Could you give some more explanations? Thanks!

songyh10 avatar Jun 19 '19 21:06 songyh10

I think it's a typo and you'd better modify it by yourself.

zxhuang97 avatar Sep 17 '19 02:09 zxhuang97