SponsorBlock icon indicating copy to clipboard operation
SponsorBlock copied to clipboard
verified publisher icon ajayyy

Updated max-width to fix overlap error

Open Choromanski opened this issue 2 years ago • 6 comments

  • [x] I agree to license my contribution under LGPL-3.0 or my contribution is from another project with a license compatible with LGPL-3.0

To test this pull request, follow the instructions in the wiki.

Solution for #1821

Before: image

After: image

Choromanski avatar Oct 24 '23 17:10 Choromanski

How does this look with the popup in the browser top right

ajayyy avatar Nov 01 '23 01:11 ajayyy

Before:

image

After:

image

I'll experiment with other solutions.

Choromanski avatar Nov 01 '23 14:11 Choromanski

Related #1429

ajayyy avatar Nov 01 '23 20:11 ajayyy

Issue #1429 results in the text running off the side of the page and can probably be closed: image

Choromanski avatar Nov 01 '23 21:11 Choromanski

The discrepancy between youtube popup and browser popup is caused by the scrollbar, how do you feel about potentially removing the scrollbar but keeping scrolling functionality?

@ajayyy

Choromanski avatar Nov 01 '23 21:11 Choromanski

Hiding scrollbars is generally bad for accessibility, so I don't think it should be done. That may be why I never noticed it because I use Linux and have a very slim scrollbar

ajayyy avatar Nov 01 '23 22:11 ajayyy