SponsorBlock icon indicating copy to clipboard operation
SponsorBlock copied to clipboard
verified publisher icon ajayyy

Implement Custom Channel Overrides

Open scaccoman opened this issue 3 years ago • 3 comments

This PR implements new custom channel override logic, which seems to be one of the most requested features:

  • https://github.com/ajayyy/SponsorBlock/issues/435
  • https://github.com/ajayyy/SponsorBlock/issues/1308
  • https://github.com/ajayyy/SponsorBlock/issues/1251
  • https://github.com/ajayyy/SponsorBlock/issues/1085
  • https://github.com/ajayyy/SponsorBlock/issues/646
Screenshot 2022-06-27 at 17 47 54

Please see the attached screen recording for a brief demo: https://user-images.githubusercontent.com/28684618/175990993-94e62021-bdc4-4309-960b-8730cd4bd097.mp4

There are some weird behaviours around disabled segment types, I'm not really sure how it's supposed to work. I would appreciate it if someone more familiar with the project (e.g. @ajayyy) could shed some light.

  • [x] I agree to license my contribution under LGPL-3.0 or my contribution is from another project with a license compatible with LGPL-3.0

scaccoman avatar Jun 27 '22 16:06 scaccoman

Thanks, but now we have two https://github.com/ajayyy/SponsorBlock/pull/1261

I do like how the configuration happens in the popup

ajayyy avatar Jun 27 '22 17:06 ajayyy

Damn, I should have checked the open PRs before investing time into this one! 😅

I've taken a look at https://github.com/ajayyy/SponsorBlock/pull/1261 and I believe it does a better job overall. IMHO, however, it doesn't mean we should scrap this PR. I believe we could easily adapt the popup.ts code to work on top of @zedseven's implementation. @ajayyy your feedback would be welcome.

scaccoman avatar Jun 28 '22 07:06 scaccoman

@scaccoman @ajayyy any news on this feature?

eirnym avatar Jan 25 '24 20:01 eirnym