SponsorBlock icon indicating copy to clipboard operation
SponsorBlock copied to clipboard

Consider respecting the system accent colour on Safari's toolbar icon

Open strafe opened this issue 2 years ago • 4 comments

I'm not familiar with extension development for Safari, but it would seem it's possible to provide a non-colour icon and allow the system accent colour to show that the extension is active.

strafe avatar May 20 '22 16:05 strafe

This seems like it should be theme-color or accent-color but there is also no dynamic elements to the icon iirc (see #930)

mchangrh avatar May 23 '22 22:05 mchangrh

@mchangrh I'm not sure what those have to do with this sorry. I did find a write up that explains Safari has some sort of built-in feature that detects if an extension's icon is grayscale or not, if it is, then it will allow it to be tinted using the system's accent colour.

This wouldn't require any additional functionality as the icon is only tinted when Safari considers the extension to be "active" (so when on youtube.com).

strafe avatar May 23 '22 23:05 strafe

Ah, I thought that Apple would at least document it or have it behind a feature flag like they did with theme or accent colour (which were reported by users), but unfortunately it seems that it's not documented and up to trial and error.

Personally I find it quite odd since SponsorBlock leans quite heavily into the red theme - IIRC 1Password isn't deliberately blending in with a greyscale icon, they just also happen to feature blue as their theme, just a happy coincidence

mchangrh avatar May 23 '22 23:05 mchangrh

1Password is using this in the screenshot I posted above. The Safari helper in 1Password 7 and below can be tinted with the system accent colour. Red example: CleanShot 2022-05-24 at 04 03 17@2x

In fact they've just changed how thinks works in 1Password 8, and the new Safari extension borrows heavily from their Chrome extension and loses this functionality, there's already a thread of people complaining.

strafe avatar May 24 '22 03:05 strafe

I can't find the update that added this but it seems to be working now(?), thanks @ajayyy image

strafe avatar Jul 06 '23 19:07 strafe

didn't do anything :P but looks nice

ajayyy avatar Jul 06 '23 19:07 ajayyy