SponsorBlock icon indicating copy to clipboard operation
SponsorBlock copied to clipboard

[Feature Request] Add peertube support

Open stemy2 opened this issue 3 years ago • 9 comments

Hello,

Sometimes i watch videos on peertube, and since SB is not compatible with it, i'm not able to skip sponsored sequences.

stemy2 avatar Feb 26 '22 17:02 stemy2

As PeerTube is federated, SponsorBlock would need to keep track of which instance is which. The current query method is not that suited to that.

erkinalp avatar Mar 06 '22 18:03 erkinalp

While I myself do not need/want PeerTube support, the problem of keeping track which instance a video is being played on could be solved by adding the domain of that instance into the videoID e.g. "peertubedomain.tld:videoID". ...though again if once instance has multiple domains this could lead to issues and for sure one wouldn't want to keep track of peertube instances' domains/main domains manually.

...though generally that PeerTube request makes sense as PeerTube support would automatically support a wide range of websites using peertube though I can imagine some issues could arise with:

  • different/older revisions of peertube
  • heavily modified peertube instances

farOverNinethousand avatar Apr 27 '22 20:04 farOverNinethousand

Domain is not needed for peertube, the IDs are unique, and can appear on multiple instances due to federation

ajayyy avatar Apr 27 '22 21:04 ajayyy

Domain is not needed for peertube, the IDs are unique,

It is, if you also want to support de-federated instances.

erkinalp avatar Apr 28 '22 16:04 erkinalp

But the id is still globally unique

ajayyy avatar Apr 28 '22 16:04 ajayyy

But the id is still globally unique

That would definitely be the easiest case.

farOverNinethousand avatar Apr 29 '22 07:04 farOverNinethousand

@ajayyy There is no such guarantee across any two instances that do not federate with each other.

@FSG-Cat

erkinalp avatar Apr 29 '22 15:04 erkinalp

I ran into this issue this week. Some channels are both on PeerTube and YouTube. I'd rather use and encourage PeerTube, but I find sponsored parts unbearable and I'm often listening to videos with no immediate access to playback controls.

Metadata gathered from one source could be used for the other source by letting users declare that a given PeerTube video is the same as some given YouTube video or vice-versa (which is most certainly easily automatable, though this automation is easily outside the scope of SponsorBlock). SponsorBlock would need to store a mapping or sets of equivalent video ids (this could also be useful for duplicate YouTube video I guess, but I'm not sure this is very useful).

Would that be conceivable?

raphj avatar Sep 10 '22 08:09 raphj