clikt icon indicating copy to clipboard operation
clikt copied to clipboard
verified publisher icon ajalt

fix: do not prompt on non-interactive terminals

Open RafeArnold opened this issue 4 months ago • 3 comments

fixes https://github.com/ajalt/clikt/issues/618

this has backwards compatibility concerns for library users' tests, as demonstrated by the need to alter this project's own existing tests. this could be considered fine as, if it is fixing incorrect behaviour, the existing test would be considered to be making incorrect assertions in the first place.

RafeArnold avatar Oct 18 '25 10:10 RafeArnold

Is there anything to be done to push this PR and https://github.com/ajalt/clikt/pull/621 through? If it's just a matter of finding the time to review then I understand.

RafeArnold avatar Dec 04 '25 13:12 RafeArnold

Sorry for the delay. Since the changes are backwards incompatible, I've been waiting until I have time to make a major version release.

ajalt avatar Dec 04 '25 17:12 ajalt

Sorry for the delay. Since the changes are backwards incompatible, I've been waiting until I have time to make a major version release.

Totally understandable. Just a heads up that https://github.com/ajalt/clikt/pull/621 is backwards compatibility, so shouldn't require a major version release.

RafeArnold avatar Dec 09 '25 13:12 RafeArnold