git-deploy icon indicating copy to clipboard operation
git-deploy copied to clipboard

Deploy fails on Git submodules

Open tmysik opened this issue 13 years ago • 3 comments

For example (app/components/DataGrid is a Git submodule):

put: STOR app/components/DataGrid
get: 150 Ok to send data.
/usr/lib/ruby/1.8/net/ftp.rb:454:in `read': Is a directory - app/components/DataGrid (Errno::EISDIR)
        from /usr/lib/ruby/1.8/net/ftp.rb:454:in `storbinary'
        from /usr/lib/ruby/1.8/net/ftp.rb:453:in `loop'
        from /usr/lib/ruby/1.8/net/ftp.rb:453:in `storbinary'
        from /usr/lib/ruby/1.8/monitor.rb:242:in `synchronize'
        from /usr/lib/ruby/1.8/net/ftp.rb:450:in `storbinary'
        from /usr/lib/ruby/1.8/net/ftp.rb:562:in `putbinaryfile'
        from /usr/lib/ruby/1.8/net/ftp.rb:591:in `put'
        from /home/gapon/bin/git-deploy:440:in `put'
        from /home/gapon/bin/git-deploy:230:in `upload'
        from /home/gapon/bin/git-deploy:216:in `each'
        from /home/gapon/bin/git-deploy:216:in `upload'
        from /home/gapon/bin/git-deploy:141:in `automate'
        from /home/gapon/bin/git-deploy:568
        from /home/gapon/bin/git-deploy:519:in `each'
        from /home/gapon/bin/git-deploy:519

tmysik avatar Feb 10 '12 09:02 tmysik

I can confirm this because I never built the util to support submodules.

aizatto avatar Feb 11 '12 18:02 aizatto

And do you plan to have a look at this issue please? Unfortunately, your app is then useless with such Git projects :/

Thanks.

tmysik avatar Feb 13 '12 09:02 tmysik

I came over the same issue and made a little patch for basic submodule support: https://github.com/Yogu/git-deploy

I quote my commit message for the limitations:

When uploading to an empty directory, submodules are skipped and user is instructed to upload the submodules manually.

On updating to a newer version, git-upload now checks whether any of the submodules were changed. If so, the changed files are uploaded.

At this point, git-upload does not support adding or removing submodules. Removals of submodules are ignored, and adding a submodule results in a warning displayed.

Yogu avatar Oct 03 '12 21:10 Yogu