devportal icon indicating copy to clipboard operation
devportal copied to clipboard

Look at CI and dependencies for AWS features

Open lornajane opened this issue 1 year ago • 0 comments

We had a pull request that passed CI but then caused a build to fail when merged to main (#1668 - dependabot bumping the aws lib)

The build was only run on merge to main, not on pull request as most of the workflows are. This is because it also deploys the functions to AWS and we don't want to overwrite them on every build.

To solve the issue:

  • figure out a test deploy option so that we put the code through the motions and know that it CAN deploy even though it's not deploying to live, and so we can use that for pull requests that touch this area of the code
  • bump the library dependency as originally intended in the first PR!

lornajane avatar Jan 04 '23 17:01 lornajane