aiven-client icon indicating copy to clipboard operation
aiven-client copied to clipboard

Enable and disable authorization in Kafka REST proxy

Open juha-aiven opened this issue 2 years ago • 1 comments

Add support for enabling and disable Kafka REST proxy authorization in a Kafka service. Adds two switches --disable-rest-proxy-authorization and --enable-rest-proxy-authorization to service update command.

juha-aiven avatar Sep 01 '22 12:09 juha-aiven

The build is failing because of this

Run make pylint
python3 -m pylint aiven tests
************* Module aiven.client.cli
aiven/client/cli.py:4814:19: W3101: Missing timeout argument for method 'requests.post' can cause your program to hang indefinitely (missing-timeout)

The PR doesn't touch line 4814 of aiven/client/cli.py.

On my laptop make pylint works both in main and in this branch.

juha-aiven avatar Sep 01 '22 13:09 juha-aiven

@tvainika comment is correct. The avn service update is generic for all services. IMO these switches should be removed --use-karapace, --enable-schema-registry-authorization, --disable-schema-registry-authorization and new service specific arguments should not be introduced.

jjaakola-aiven avatar Sep 06 '22 11:09 jjaakola-aiven