logdata-anomaly-miner icon indicating copy to clipboard operation
logdata-anomaly-miner copied to clipboard

Change persistence handling to standardize saving dictionaries as json in JsonUtil.encode_object

Open ernstleierzopf opened this issue 3 years ago • 5 comments

For example like in the EFD:

for log_ev, freq in self.counts_prev.items(): persist_data.append((log_ev, freq))

ernstleierzopf avatar Mar 16 '21 09:03 ernstleierzopf

Idea: use the old pull request to create a concept of persisting data and adapt it at a per class basis.

ernstleierzopf avatar Apr 26 '22 11:04 ernstleierzopf

Also change persistence after creating new unittests - wait before a major release.

ernstleierzopf avatar Apr 26 '22 11:04 ernstleierzopf

ToDo after unittests for the analysis classes are created - always also check the persisted data format on disk. These are breaking changes and need to be done before a new release.

ernstleierzopf avatar Apr 25 '23 06:04 ernstleierzopf

save ETD data as dictionary.

ernstleierzopf avatar May 07 '23 08:05 ernstleierzopf

#300 is related.

ernstleierzopf avatar May 23 '23 09:05 ernstleierzopf

I think there will never be a good opportunity to implement this this issue, because these would be breaking changes for existing deployments. There could be an automatic tool to update existing persisted data, but it might not be worth the implementation time and risks involved. The benefits simply do not outweight the risks and hassle.

@landauermax do you agree?

ernstleierzopf avatar Aug 05 '24 16:08 ernstleierzopf

Yes I agree, it is high risk and not worth it just for the sake of standardization.

landauermax avatar Aug 06 '24 05:08 landauermax