mudrod icon indicating copy to clipboard operation
mudrod copied to clipboard

ESdriver cleanup

Open Yongyao opened this issue 8 years ago • 3 comments

@quintinali Can you move these two searchbyQuery() used by datasetDetail to somewhere else. Maybe a separate class in search package. It's bit messy here.

https://github.com/mudrod/mudrod/blob/master/core/src/main/java/esiptestbed/mudrod/driver/ESDriver.java#L249

Yongyao avatar Sep 29 '16 15:09 Yongyao

yes it is. We should have a separate ESDriverSearch class.

lewismc avatar Sep 30 '16 04:09 lewismc

Ok. I will let you know after I do the modification.

quintinali avatar Sep 30 '16 20:09 quintinali

The purpose of this issue is to introduce a MudrodDriver.java interface, and for ESDriver.java to begin implementing some of the functions. This is the way it should have been implemented originally. The same should be true for SparkDriver.java. It should merely implement MudrodDriver.java

lewismc avatar May 03 '17 14:05 lewismc