node-webrtc icon indicating copy to clipboard operation
node-webrtc copied to clipboard
verified publisher icon aisouard

Windows: Fix hanging issue during cleanup

Open aisouard opened this issue 8 years ago • 4 comments

Appveyor is failing after running the tests, this is certainly due to the changes over there: https://github.com/aisouard/node-webrtc/commit/eb9ea40095bff95f7e5061d02f668c5767eaddb8

aisouard avatar Mar 15 '17 08:03 aisouard

It's hanging again under OSX... https://travis-ci.org/aisouard/node-webrtc/jobs/216071123

aisouard avatar Mar 28 '17 19:03 aisouard

It comes from that line, https://github.com/aisouard/node-webrtc/blob/develop/src/globals.cc#L65

The current thread is set as the signaling one, but the signaling thread is used as the worker thread, I should pay more attention.

Testing under Windows before pushing again.

aisouard avatar Mar 29 '17 06:03 aisouard

The issue is way more complicated, it seems that Node is not really happy with ref counted objects. Will be fixed tonight.

aisouard avatar Mar 29 '17 11:03 aisouard

Travis got stuck on that one, but it seems fixed. Will reopen if it happens again.

aisouard avatar Mar 29 '17 18:03 aisouard