Update to Rust 2021, and auto-apply clippy lints

[Swatinem]

Summary by CodeRabbit

• New Features

  • Updated the Rust edition to 2021 for improved language features.
  • Enhanced default initialization for ClientBuilder and TlsOptions.
  • Streamlined data handling and error checking across various methods.

• Refactor

  • Improved code readability and efficiency in client.rs and connection.rs.
  • Simplified conditions and assertions in protocol/ascii.rs and tests.rs.
  • Removed outdated configurations and unused fields.

• Bug Fixes

  • Fixed incorrect method checks and data writing issues in ASCII protocol handling.
  • Enhanced assertions in tests for more accurate error detection.

[coderabbitai[bot]]

Walkthrough

The recent updates to the codebase focus on modernizing and simplifying the Rust project. Key improvements include upgrading the Rust edition, refining pattern matching, enhancing error handling, and optimizing data structures and method calls for clarity and efficiency. These changes aim to make the code more readable, maintainable, and aligned with current Rust standards.

Changes

Files	Changes Summary
Cargo.toml	Updated Rust edition from 2018 to 2021.
src/client.rs	Enhanced pattern matching, simplified error handling, and initialization, improved method calls and checks for readability.
src/connection.rs	Streamlined initialization, improved handling of options and fields, and updated scheme and port checks.
src/lib.rs	Removed unnecessary cfg_attr attribute for cargo-clippy feature.
src/protocol/ascii.rs	Major refactoring in handling strings and buffers, updated constants, and streamlined logic in ASCII protocol operations.
tests/tests.rs	Refactored assertions, simplified error checks, and improved thread handling in tests.

Poem

🐇💻✨
In the fields of code, where logic threads weave,
A rabbit hopped by, with updates to achieve.
Refactored with care, each line and each byte,
Now cleaner, more swift, a developer's delight.
Hop, skip, and a jump, the codebase does gleam,
In the glow of Rust's light, it's a coder's dream.
🌟📜🚀

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 15fb25e4e62fd6aa23e6dd8cef7fc65808bf29ca and cb8fe1614cc40a0d44bfc04a1a0a3321e7f3f075.

Files selected for processing (2)

• src/client.rs (28 hunks)
• src/connection.rs (9 hunks)

Files skipped from review as they are similar to previous changes (2)

• src/client.rs
• src/connection.rs

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[aisk]

Thanks for the contribution! At first glance, I want to know if this change is just do the auto apply clippy lints? If so, I want to wait for #147 to be merged to decrease the conflict risks.

[Swatinem]

There is a bunch of other optimizations as well, but no rush here.

Eventually, I might want to also improve the way that hash_function works, as right now its a function pointer, and it might be nice to turn that into a Box<Fn> so that it can hold state for consistent hashing.

[Shahab96]

Thanks for the contribution! At first glance, I want to know if this change is just do the auto apply clippy lints? If so, I want to wait for #147 to be merged to decrease the conflict risks.

That PR is good to go, just needs review.