airswap-web icon indicating copy to clipboard operation
airswap-web copied to clipboard

Test with localstorage disabled

Open gpxl-dev opened this issue 3 years ago • 2 comments

Was reading a thread about a site that crashes on some browser/settings combos because there are no permissions checks wrapped around localstorage use

https://twitter.com/triangulo_dev/status/1437507948595531779?s=19

gpxl-dev avatar Sep 14 '21 06:09 gpxl-dev

Here's a good way to check for it: https://developer.mozilla.org/en-US/docs/Web/API/Web_Storage_API/Using_the_Web_Storage_API#feature-detecting_localstorage

What do you want to do when it's unavailable?

robbestad avatar Oct 05 '21 19:10 robbestad

I think all of the localStorage functionality we have is non-critical - as long as the core still works (i.e. if errors are thrown they're handled gracefully), then we're okay.

gpxl-dev avatar Oct 05 '21 20:10 gpxl-dev