asv icon indicating copy to clipboard operation
asv copied to clipboard

Warn if benchmark version looks wrong

Open saraedum opened this issue 5 years ago • 2 comments

Should we add a warning if the version of a benchmark that asv determines looks wrong?

In my case, my benchmarks contained from sage.all import * which pulls in a version(). Therefore, all graphs generated by asv only contain the latest commit; instead of the source code's hash, asv uses the mostly random <function version at 0x7faeb5da7668> to identify the benchmark.

It took me quite a while to figure this out. Maybe we could include the version in some logging that shows with enough --verbose flags?

saraedum avatar Jan 22 '20 13:01 saraedum

On a second thought. Why would one ever want to pull the version from the module attributes?

saraedum avatar Jan 22 '20 13:01 saraedum

cc @videlec, this is the issue at https://gitlab.com/jo314schmitt/admcycles.

saraedum avatar Jun 16 '20 20:06 saraedum