airr-standards icon indicating copy to clipboard operation
airr-standards copied to clipboard

Is linked_subjects in Subject for single or multiple subject links?

Open schristley opened this issue 2 years ago • 4 comments

The field name as plural suggests multiple, but the description is written as though single. Also the fact that it's a single text field suggests single. Though it seems like supporting multiple would be desirable, like linking both mother and father for genealogy. If the intent is multiple then I'd suggesting using the flexibility of JSON schema and make it an array of objects where each object contains the subject id and link type.

schristley avatar Sep 27 '23 19:09 schristley

+1 for an array of objects. Does anyone have a good ontology for link_type terms? Should include both genetic as well as exposure relationships. I had a look at OBO, but could not find anything suitable...

bussec avatar Sep 29 '23 10:09 bussec

I did find the FHHO but it does not have exposure relationships.

schristley avatar Sep 29 '23 16:09 schristley

Did some more digging, and SNOMED CT has a rather comprehensive set of relations. If there wouldn't the issue that it is not available under an open license...

bussec avatar Sep 29 '23 20:09 bussec

v2.0 consideration? I have added it for now - seems like a small change other than sorting out the relationship question.

bcorrie avatar Feb 07 '24 22:02 bcorrie