sgd icon indicating copy to clipboard operation
sgd copied to clipboard

Cannot use SGD with sparse matrix

Open jeffwong-nflx opened this issue 8 years ago • 5 comments

Hi, great package! I noticed that you can only use the sgd(x = ..., y = ...) interface if x is either a big matrix or a matrix, but not a sparse matrix as in the result of sparse.model.matrix. This support would be great

jeffwong-nflx avatar Nov 24 '16 01:11 jeffwong-nflx

thanks Jeff! Indeed, working on sparse models is a priority.

ptoulis avatar Nov 24 '16 01:11 ptoulis

Since you are using RcppArmadillo, the equivalent class would be a arma::sp_mat instead of arma::mat. Is it just a matter of changing the Rcpp interfaces ? If so I could help with that

jeffwong-nflx avatar Nov 24 '16 02:11 jeffwong-nflx

@dustinvtran would this change interfere with any changes you are currently implementing?

ptoulis avatar Nov 24 '16 02:11 ptoulis

Duplicate #85

dselivanov avatar Nov 24 '16 04:11 dselivanov

apologies for the (very) delayed response; from a cursory glance it would be as simple as changing those classes.

dustinvtran avatar Jan 16 '17 14:01 dustinvtran