Hardcoded version of mmdet

Open FrancescoSaverioZuppichini opened this issue 4 years ago • 3 comments

Hello there,

I hope you are doing great!

🐛 Bug

Describe the bug You hardcoded the version of mmdet -> https://github.com/airctic/icevision/blob/989e50a4c49a0505b5d340d1f585154c7f7e480f/icevision/models/mmdet/download_configs.py#L6

You should dynamically import mmdet and get the __version__ from it. This causes endless compatibility problems making icevision virtually impossible to use without forcing yourself to use a old version of mmdet (icevision release uses the 2.10.0).

Thank you!

Cheers,

Francesco

Oct 05 '21 09:10 FrancescoSaverioZuppichini

@ai-fast-track do you know why we are doing this?

Dec 18 '21 17:12 FraPochetti

@ai-fast-track wdyt?

Dec 31 '21 07:12 FraPochetti

From what i understand this line of code is used to import the config file version from this repo. It does not affect the mmdet version installed with IceVision.

The latest stable mmdet version that can run all models on IceVision is mmdet==2.17.0. I have tried mmdet==2.20.0 but VFNet model fails to run.

Jan 29 '22 13:01 dnth